[google_maps_flutter] Update google_maps_flutter to 2.16.0#1019
Open
JSUYA wants to merge 3 commits into
Open
Conversation
* Update google_maps_flutter to 2.16.0. * Update google_maps_flutter_platform_interface to 2.15.0. * Add support for ground overlays (bounds-based) via google.maps.GroundOverlay. * Forward the colorScheme map option to google.maps.ColorScheme.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds ground overlay support and the colorScheme map option to the Tizen implementation of google_maps_flutter. Review feedback points out that the implementation currently ignores updates to immutable ground overlay properties such as url and bounds, suggesting these should trigger a recreation of the overlay. Additionally, a memory leak was identified in the GroundOverlaysController where internal ID mappings are not removed when an overlay is deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#992