Skip to content

Removes unused code in DevTools app extensions/ and framework/ directories #9909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kenzieschmoll wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Removes unused code in DevTools app extensions/ and framework/ directories #9909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
44523e7
Add check-unused-code to DCM CI checks.
kenzieschmoll Jul 21, 2026
76e7220
exclude public API
kenzieschmoll Jul 21, 2026
93ec692
Add excludes
kenzieschmoll Jul 21, 2026
6ebb76b
exclude test/
kenzieschmoll Jul 21, 2026
00d014e
exclude service/
kenzieschmoll Jul 21, 2026
0b896c5
exclude integration_test/
kenzieschmoll Jul 21, 2026
6d414f7
Ignore false positives in app.dart.
kenzieschmoll Jul 21, 2026
03c168c
Remove unused code in extensions/ and framework/
kenzieschmoll Jul 21, 2026
1e8add7
use if (kDebugMode)
kenzieschmoll Jul 21, 2026
6c38057
remove other assert
kenzieschmoll Jul 21, 2026
3a6e280
merge
kenzieschmoll Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,6 @@ dart_code_metrics:
# TODO(https://github.com/flutter/devtools/issues/9906) remove these
# excludes as findings are resolved.
- integration_test/**
- lib/src/extensions/**
- lib/src/framework/**
- lib/src/screens/**
- lib/src/service/**
- lib/src/shared/**
Expand Down
1 change: 1 addition & 0 deletions packages/devtools_app/lib/src/extensions/embedded/_controller_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ class EmbeddedExtensionControllerImpl extends EmbeddedExtensionController
final extensionPostEventStream =
StreamController<DevToolsExtensionEvent>.broadcast();

// ignore: unused-code, TODO(https://github.com/flutter/devtools/issues/9907): false positive.
bool _initialized = false;

@override
Expand Down
7 changes: 4 additions & 3 deletions packages/devtools_app/lib/src/extensions/embedded/_view_desktop.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ import 'package:flutter/material.dart';
import 'controller.dart';

class EmbeddedExtension extends StatelessWidget {
const EmbeddedExtension({super.key, required this.controller});

final EmbeddedExtensionController controller;
const EmbeddedExtension({
super.key,
required EmbeddedExtensionController controller,
});

@override
Widget build(BuildContext context) {
Expand Down
1 change: 1 addition & 0 deletions packages/devtools_app/lib/src/extensions/extension_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ class ExtensionService extends DisposableController
///
/// This set of extensions will include one version of a DevTools extension
/// per package.
@visibleForTesting
List<DevToolsExtensionConfig> get availableExtensions =>
_currentExtensions.value.availableExtensions;

Expand Down
7 changes: 1 addition & 6 deletions packages/devtools_app/lib/src/framework/home_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ class HomeScreen extends Screen {
titleGenerator: () => devToolsTitle.value,
);

static final id = ScreenMetaData.home.id;

final List<DevToolsJsonFile> sampleData;

@override
Expand Down Expand Up @@ -165,10 +163,7 @@ class _ConnectInputState extends State<ConnectInput> with BlockingActionMixin {
void initState() {
super.initState();
connectDialogController = TextEditingController();
assert(() {
_debugInitVmServiceCache();
return true;
}());
if (kDebugMode) _debugInitVmServiceCache();

@gemini-code-assist gemini-code-assist Bot Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

[CONCERN] Since _debugInitVmServiceCache is an asynchronous method that calls setState, it can potentially lead to a "setState() called after dispose()" exception if the widget is disposed before the async operation completes. Consider adding a mounted check before calling setState inside _debugInitVmServiceCache.

Additionally, for consistency with this change, consider updating the saving side in _connectHelper (around line 256) to use if (kDebugMode) instead of assert.

References
  1. Prefix every comment with a severity: [MUST-FIX], [CONCERN], [NIT]. (link)

}

void _debugInitVmServiceCache() async {
Expand Down
1 change: 1 addition & 0 deletions packages/devtools_app/lib/src/framework/release_notes.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ bool debugTestReleaseNotes = false;
// from the flutter/website PR, which has a GitHub action that automatically
// stages commits to firebase. Example:
// https://flutter-docs-prod--pr12652-devtools-release-notes-2-52-3bbb8c0u.web.app/tools/devtools/release-notes/release-notes-2.52.0.md.
// ignore: unused-code, debug-only feature.
String? _debugReleaseNotesUrl;

const releaseNotesKey = Key('release_notes');
Expand Down
2 changes: 0 additions & 2 deletions packages/devtools_app/lib/src/framework/scaffold/status_line.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ class StatusLine extends StatelessWidget {
/// Whether to highlight the footer when DevTools is connected to an app.
final bool highlightForConnection;

static const deviceInfoTooltip = 'Device Info';

/// The padding around the footer in the DevTools UI.
EdgeInsets get padding => const EdgeInsets.symmetric(
horizontal: defaultSpacing,
Expand Down
Loading