Skip to content

[material_ui] Remove redundant disabledBorder check in InputDecorationThemeData - #12797

Open
MohanadAbdallah-mv wants to merge 1 commit into
flutter:mainfrom
MohanadAbdallah-mv:fix-redundant-disabled-border-check
Open

[material_ui] Remove redundant disabledBorder check in InputDecorationThemeData#12797
MohanadAbdallah-mv wants to merge 1 commit into
flutter:mainfrom
MohanadAbdallah-mv:fix-redundant-disabled-border-check

Conversation

@MohanadAbdallah-mv

Copy link
Copy Markdown

Removes a duplicate condition in the == operator of InputDecorationThemeData.
The check other.disabledBorder == disabledBorder appeared twice ,This was noticed during the review of flutter/flutter#183582.
No behavior change since the duplicate was always true when reached.

List which issues are fixed by this PR. You must list at least one issue.
Port of flutter/flutter#187556

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a redundant disabledBorder check from the equality operator (==) in InputDecorationThemeData within input_decorator.dart. It also adds a corresponding changelog entry. There are no review comments, and I have no feedback to provide.

@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Sep 9, 2026
@MohanadAbdallah-mv

Copy link
Copy Markdown
Author

@Renzo-Olivares @QuncCccccc
This current PR is a port of flutter/flutter#187556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant