Skip to content

[vector_graphics] Remove unnecessary Material imports #12798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ricardodalarme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[vector_graphics] Remove unnecessary Material imports #12798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/vector_graphics/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## NEXT

* Removes unnecessary Material imports.
* Fixes deprecation lints.

## 1.2.3
Expand Down
2 changes: 1 addition & 1 deletion packages/vector_graphics/test/caching_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import 'dart:async';
import 'dart:typed_data';

import 'package:flutter/material.dart';
import 'package:flutter/widgets.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:vector_graphics/src/vector_graphics.dart';
import 'package:vector_graphics_codec/vector_graphics_codec.dart';
Expand Down
9 changes: 6 additions & 3 deletions packages/vector_graphics/test/render_vector_graphics_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ library;
import 'dart:typed_data';
import 'dart:ui' as ui;

import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter/widgets.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:vector_graphics/src/listener.dart';
import 'package:vector_graphics/src/render_vector_graphic.dart';
Expand Down Expand Up @@ -115,7 +115,10 @@ void main() {

final ui.Image firstImage = context.canvas.lastImage!;

renderVectorGraphic.colorFilter = const ui.ColorFilter.mode(Colors.red, ui.BlendMode.colorBurn);
renderVectorGraphic.colorFilter = const ui.ColorFilter.mode(
ui.Color(0xFFFF0000),
ui.BlendMode.colorBurn,
);
renderVectorGraphic.paint(context, Offset.zero);

expect(firstImage.debugDisposed, false);
Expand Down Expand Up @@ -288,7 +291,7 @@ void main() {
test('Color filter applies clip', () async {
final render = RenderPictureVectorGraphic(
pictureInfo,
const ui.ColorFilter.mode(Colors.green, ui.BlendMode.difference),
const ui.ColorFilter.mode(ui.Color(0xFF00FF00), ui.BlendMode.difference),
null,
);
render.layout(BoxConstraints.tight(const Size(50, 50)));
Expand Down
4 changes: 2 additions & 2 deletions packages/vector_graphics/test/vector_graphics_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import 'dart:async';
import 'dart:convert' show base64Decode;

import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter/widgets.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:vector_graphics/src/listener.dart';
import 'package:vector_graphics/src/vector_graphics.dart';
Expand Down Expand Up @@ -575,7 +575,7 @@ void main() {
textDirection: TextDirection.ltr,
child: createCompatVectorGraphic(
loader: const AssetBytesLoader('foo.svg'),
colorFilter: const ColorFilter.mode(Colors.red, BlendMode.srcIn),
colorFilter: const ColorFilter.mode(Color(0xFFFF0000), BlendMode.srcIn),
opacity: const AlwaysStoppedAnimation<double>(0.5),
),
),
Expand Down