Skip to content

[material_ui] Port flutter/flutter #185475 "Accessibility: Add semanticLabel to MenuAnchor" - #12806

Open
mbcorona wants to merge 5 commits into
flutter:mainfrom
mbcorona:port-185475
Open

[material_ui] Port flutter/flutter #185475 "Accessibility: Add semanticLabel to MenuAnchor"#12806
mbcorona wants to merge 5 commits into
flutter:mainfrom
mbcorona:port-185475

Conversation

@mbcorona

@mbcorona mbcorona commented Sep 9, 2026

Copy link
Copy Markdown
Member

Ports flutter/flutter#185475 to material_ui, following the instructions in flutter/flutter#188444. The commits were cherry-picked from the original PR, with only file paths adjusted for this repo.

MenuAnchor had no way to label the expanded menu overlay, so screen readers announced nothing useful when a menu opened. This adds a semanticLabel property, applied to a Semantics node wrapping the submenu in _buildOverlay, and only when a label is provided.

The original PR also announced the label with SemanticsService.announce when the menu opened. Following @chunhtai's review feedback on flutter/flutter#185475, that part is dropped here: a semantics label should not double as announcement text, and anyone who wants an announcement can call SemanticsService.announce from onOpen. The last commit on this branch removes it.

Tests

New test MenuAnchor applies semanticLabel to the expanded menu overlay in packages/material_ui/test/menu_anchor_test.dart, checking that the label is absent before the menu opens and present once it expands. The menu_anchor.0 API example now sets a semanticLabel, and its example test still passes.

Fixes flutter/flutter#184876

Supersedes flutter/flutter#185475, which will be closed with a pointer to this PR.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 9, 2026
@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Sep 9, 2026
@mbcorona
mbcorona requested a review from chunhtai September 9, 2026 12:17

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a semanticLabel property to the MenuAnchor widget, wrapping the expanded menu overlay in a Semantics widget when a label is provided. A corresponding test case and example update are also included. The review feedback recommends setting explicitChildNodes: true on the Semantics widget to ensure child menu items are treated as separate interactive nodes in the semantics tree.

Comment thread packages/material_ui/lib/src/menu_anchor.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No Accessibility label on expanded menu of MenuAnchor

1 participant