Skip to content

[material_ui] Migrate M3 Checkbox defaults to new gen_defaults - #12816

Open
QuncCccccc wants to merge 1 commit into
flutter:mainfrom
QuncCccccc:checkbox_m3_defaults_migration
Open

[material_ui] Migrate M3 Checkbox defaults to new gen_defaults#12816
QuncCccccc wants to merge 1 commit into
flutter:mainfrom
QuncCccccc:checkbox_m3_defaults_migration

Conversation

@QuncCccccc

Copy link
Copy Markdown
Contributor

Work toward flutter/flutter#187899

Fixes flutter/flutter#

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 9, 2026
@QuncCccccc QuncCccccc added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Sep 9, 2026
@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Sep 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the generation of Material 3 Checkbox defaults to the new token-based template system (CheckboxTemplateM3), moving the generated code from checkbox.dart into a separate part file. It also enables and tests this generation. The reviewer suggested a correction in checkbox_template.dart to use the semantically correct token TokenCheckbox.unselectedOutlineWidth instead of TokenCheckbox.unselectedDisabledOutlineWidth for the error state border side to ensure future-proofing.

Comment thread packages/material_ui/tool/gen_defaults/templates/checkbox_template.dart Outdated
@QuncCccccc
QuncCccccc force-pushed the checkbox_m3_defaults_migration branch from cb279fd to 3001faa Compare September 10, 2026 18:43
@QuncCccccc
QuncCccccc requested a review from elliette September 10, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

checkbox_template.dart

1 participant