[material_ui] Add trailingIconVisibility to ExpansionPanel (#179167) - #12819
[material_ui] Add trailingIconVisibility to ExpansionPanel (#179167)#12819benji-farquhar wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request introduces the ExpansionPanelIconVisibility enum and a corresponding trailingIconVisibility property to ExpansionPanel and ExpansionPanelRadio to control the visibility of the trailing expand/collapse icon. It also includes an example application, unit tests, and integration tests. The review feedback correctly identifies multiple instances where enum values are referenced using invalid leading dot shorthand (e.g., .visible, .hidden, .gone) instead of their fully qualified names, which will cause compilation errors in Dart.
8aa887c to
18be17e
Compare
Ports flutter/flutter#183951 to
material_ui, following the instructions in flutter/flutter#188444.Description
Introduces the
ExpansionPanelIconVisibilityenum (visible,hidden,gone) toExpansionPanel.trailingIconVisibility.This allows controlling whether the trailing expand/collapse icon is visible, hidden (preserving its layout space for alignment), or gone (removed from layout completely).
Fixes flutter/flutter#179167
Supersedes flutter/flutter#183951
cc @dkwingsmt @victorsanni who previously reviewed and approved the original PR in flutter/flutter#183951.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2