[material_ui] Keep ExpansionPanelList dividers when expanded with 0 materialGapSize (#183974) - #12820
Open
benji-farquhar wants to merge 1 commit into
Open
Conversation
…aterialGapSize (#183974) Fixes flutter/flutter#183974
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies ExpansionPanelList to preserve dividers and avoid inserting a MaterialGap when materialGapSize is set to 0. It includes documentation updates, a new example, and corresponding tests. The review feedback identifies syntax errors in the new example file where the EdgeInsets prefix was omitted on several padding properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#183974
Supersedes flutter/flutter#183975
Ports the change originally submitted in flutter/flutter#183975 to
packages/material_ui.cc @dkwingsmt @victorsanni who previously reviewed and approved the original PR in flutter/flutter#183975.
Description
When
ExpansionPanelList.materialGapSizeis set to0,MaterialGapis no longer inserted between expanded panels. This allowsMergeableMaterialto preserve the dividers between adjacent expanded panels, creating a clean flat list appearance (ideal for nested lists or panels within cards).This is the end result of the PR (before it, the dividers between panels were absent):

MaterialGapinsertion inExpansionPanelListwithmaterialGapSize > 0.materialGapSizewith a<callout-box>.expansion_panel_list.2.dart) and widget tests.expansion_panel_test.dartto verify gap insertion and zero-gap divider retention.Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2