[material_ui] Port PR (#187366) from flutter/flutter to material_ui - #12821
Open
ishivamg wants to merge 1 commit into
Open
[material_ui] Port PR (#187366) from flutter/flutter to material_ui#12821ishivamg wants to merge 1 commit into
ishivamg wants to merge 1 commit into
Conversation
…nu is open Defer Navigator.removeRoute until after the current frame when orientation changes during build. This ports the reviewed fix from flutter/flutter#187366. Fixes flutter/flutter#171011
github-actions
Bot
added
p: material_ui
triage-design
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request defers the dismissal of the dropdown route during orientation changes if the scheduler is in the persistent callbacks phase, preventing Navigator mutation during the build phase. It also adds a corresponding widget test to verify this behavior and a changelog entry. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports flutter/flutter#187366 to
material_ui.When a
DropdownButtonmenu is open (especially inside a dialog) and the device orientation changes,_DropdownButtonState.build()dismissed the route withNavigator.removeRoute()during build. That triggerssetState() or markNeedsBuild() called during build.The route is now removed synchronously unless we are in
SchedulerPhase.persistentCallbacks, in which case removal is deferred to a post-frame callback.Fixes flutter/flutter#171011
Follows flutter/flutter#188444