Skip to content

Enable recent lints for site tooling and implementation - #13845

Open
parlough wants to merge 3 commits into
mainfrom
misc/3-13-new-lints
Open

Enable recent lints for site tooling and implementation#13845
parlough wants to merge 3 commits into
mainfrom
misc/3-13-new-lints

Conversation

@parlough

@parlough parlough commented Sep 2, 2026

Copy link
Copy Markdown
Member
  • Enables some new and some pre-existing lints for site tooling and implementation.
  • Fixes diagnostics reported after enabling those lints.
  • Temporarily enabled some others to address certain cases of them.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the linter rules in analysis.yaml, bumps the SDK version constraint to ^3.13.0, and applies various code cleanups across multiple packages, such as optimizing const usage, simplifying pattern matching, and removing redundant async keywords. The reviewer identified two critical resource leaks: a memory leak in _TooltipState due to an uncancelled window resize event listener, and a file handle leak in TrackingAssetTransformer because the IOSink is never closed.

Comment thread packages/site_shared/lib/components/common/tooltip.dart
Comment thread sites/www/lib/src/utils/asset_utils.dart Outdated
@flutter-website-bot

Copy link
Copy Markdown
Collaborator

Staged preview of the updated docs.flutter.dev site (updated for commit ab4abb0):

https://flutter-docs-prod--docs-pr13845-misc-3-13-new-lints-h9bynf5e.web.app

@flutter-website-bot

Copy link
Copy Markdown
Collaborator

Staged preview of the updated flutter.dev site (updated for commit ab4abb0):

https://flutter-dev-230821--www-pr13845-misc-3-13-new-lints-amaj0j8n.web.app

@sfshaza2 sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@parlough parlough self-assigned this Sep 8, 2026
@parlough
parlough marked this pull request as draft September 8, 2026 20:55
@parlough
parlough marked this pull request as ready for review September 10, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants