fix(network_info_plus): Fix subnet mask and broadcast on Linux - #3942
Open
source-creator wants to merge 2 commits into
Open
fix(network_info_plus): Fix subnet mask and broadcast on Linux#3942source-creator wants to merge 2 commits into
source-creator wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Linux, an incorrect subnet mask and broadcast mask is returned if the network prefix is not byte aligned.
For example, a prefix of /24 works, but /22 doesn't.
This is due to incorrect bit operations in addition to incorrect byte ordering in the Linux Dart code, where network byte order should rather be used.
The current code:
The updated code:
Source: https://www.ibm.com/docs/en/zvm/7.4.0?topic=domains-network-byte-order-host-byte-order
Related Issues
fixes: #3941
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).