Fix FMT_COMPILE failure with format_as mapped types (Issue #4794)#4836
Open
upadhyay74aman wants to merge 3 commits into
Open
Fix FMT_COMPILE failure with format_as mapped types (Issue #4794)#4836upadhyay74aman wants to merge 3 commits into
upadhyay74aman wants to merge 3 commits into
Conversation
phprus
reviewed
Jul 5, 2026
vitaut
requested changes
Jul 5, 2026
This comment has been minimized.
This comment has been minimized.
vitaut
force-pushed
the
fix-compile-format-as
branch
from
15cfdd0 to
5701167
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
FMT_COMPILEfails to compile when used with user-defined types formatted viaformat_as.The Changes:
Introduced
compile_has_format_asto check forformat_asoverloads at compile time via ADL.Updated the
formatmethod insidedetail::fieldincompile.hto branch usingif constexpr, casting the argument viaformat_asif the type supports it.Added a regression test to
test/compile-test.ccto ensure compile-timeformat_asevaluation works as expected.Closes #4794