Make fmt::as_identifiers a struct instead of a variable - #4900
Open
avikivity wants to merge 1 commit into
Open
Conversation
The annotation was a constant of an empty type, which left no room for
options. Make the annotation type itself, fmt::as_identifiers, the thing
users write, so it is now spelled
enum class [[=fmt::as_identifiers()]] color { red, green, blue };
and options can later be added as constructor arguments.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Note: this logically conflicts with #4899. If you want both (and you should), merge one and I'll refresh the other. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The annotation was a constant of an empty type, which left no room for options. Make the annotation type itself, fmt::as_identifiers, the thing users write, so it is now spelled
enum class [[=fmt::as_identifiers()]] color { red, green, blue };
and options can later be added as constructor arguments.