Skip to content

@W-21771476: feat: add HasVpi to package version list and report queries [DO NOT MERGE until 6/4 262.8 deploy]#875

Merged
iowillhoit merged 3 commits into
mainfrom
t/managed-packaging/w-21771476/display-hasvpi-field-in-package-version-commands
Jun 5, 2026
Merged

@W-21771476: feat: add HasVpi to package version list and report queries [DO NOT MERGE until 6/4 262.8 deploy]#875
iowillhoit merged 3 commits into
mainfrom
t/managed-packaging/w-21771476/display-hasvpi-field-in-package-version-commands

Conversation

@tporcaro-sf
Copy link
Copy Markdown
Collaborator

@tporcaro-sf tporcaro-sf commented Jun 2, 2026

@W-21771476@

Summary

  • Add HasVpi boolean field to package version list and report queries
  • Version-gated at API v67+ (app version 262)
  • Field added to Package2VersionFields, verboseFields (list), and default67Fields (report)
  • Unit tests + NUT tests for version gate behavior

Dependencies

  • Requires W-21771475 (262.8 patch) to be fully deployed (scheduled 6/4)
  • Plugin-packaging PR depends on this merging first

Test plan

  • Unit tests: constructQuery(67, verbose) includes HasVpi, constructQuery(66, verbose) excludes it
  • NUT tests: getPackage2VersionFields at v66 excludes, v67 includes
  • Manual testing on 262 devhub (hub0318) and 260 devhub (hub1215)

🤖 Generated with Claude Code

@salesforce-cla
Copy link
Copy Markdown

salesforce-cla Bot commented Jun 2, 2026

Thanks for the contribution! It looks like @tjporcaro is an internal user so signing the CLA is not required. However, we need to confirm this.

@tporcaro-sf tporcaro-sf force-pushed the t/managed-packaging/w-21771476/display-hasvpi-field-in-package-version-commands branch from 4252b5a to 9f12317 Compare June 2, 2026 18:31
@tporcaro-sf
Copy link
Copy Markdown
Collaborator Author

tporcaro-sf commented Jun 2, 2026

⚠️ NUT failures are pre-existing — not related to this PR.

The 5 failing tests exist on main and are caused by:

  • Tests 1-3: hardcoded 05i Package2Version IDs that don't exist on the CI devhub (NOT_FOUND)
  • Tests 4-5: delete operations hitting NOT_FOUND (CI devhub timing/state issue)

Our HasVpi tests pass:

  • should not contain HasVpi field with api version 66
  • should contain HasVpi field with api version 67

cc: @KSCCO @shetzel

@tporcaro-sf
Copy link
Copy Markdown
Collaborator Author

@KSCCO this pr containing packaging library changes to support HasVpi in the version list and report queries also require your review. This is consumed by the dependent plugin changes. Thanks!

Comment thread src/package/packageVersionReport.ts Outdated
Comment thread src/package/packageVersionReport.ts Outdated
Copy link
Copy Markdown
Collaborator

@KSCCO KSCCO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple comments, you can consider them optional

@tporcaro-sf
Copy link
Copy Markdown
Collaborator Author

tporcaro-sf commented Jun 4, 2026

@shetzel These packaging lib changes should be good to merge now assuming they will be included in next Wed's cadence promotion to RC and stable the following Wed. fyi ... Once these merge I will also need to bump the dependency version on my downstream packaging plugin PR and merge those in next. See salesforcecli/plugin-packaging#1213
Thanks for the help!
cc: @KSCCO

@iowillhoit
Copy link
Copy Markdown
Contributor

iowillhoit commented Jun 5, 2026

NUT failures are pre-existing — not related to this PR.

I don't see any other PRs (open or merged) that have these NUT failures. Where are you seeing that these failures are pre-existing?

Latest open PR (NUTs passing)
Latest closed PR (NUTs passed)

@tporcaro-sf
Copy link
Copy Markdown
Collaborator Author

@iowillhoit You are correct. It turned out to be a an issue with my new tests not restoring the api version on the connection, thus affecting downstream tests . I pushed a commit and all nuts now passing now. Thanks!

@tporcaro-sf tporcaro-sf requested a review from iowillhoit June 5, 2026 18:58
@iowillhoit iowillhoit merged commit c23564e into main Jun 5, 2026
12 of 13 checks passed
@iowillhoit iowillhoit deleted the t/managed-packaging/w-21771476/display-hasvpi-field-in-package-version-commands branch June 5, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants