fix: support '#' version separator in AiAgentDefinitionVersion @W-23939860@ - #1826
Open
WillieRuemmele wants to merge 5 commits into
Open
fix: support '#' version separator in AiAgentDefinitionVersion @W-23939860@#1826WillieRuemmele wants to merge 5 commits into
WillieRuemmele wants to merge 5 commits into
Conversation
…mes @W-23939860@
AiAgentDefinitionVersion uses '#' as its version separator (e.g., 'ASA1#1'),
which conflicts with SDR's internal KEY_DELIMITER that also uses '#' for
composite keys (type#fullName). This change:
- Fixes key.split('#') in metadataApiDeploy to split only on the first '#'
- Adds registry suffix and versionSeparator field for AiAgentDefinitionVersion
- Adds parseAgentVersionFullName for version filter parsing
- Adds componentSetBuilder handling for AiAgentDefinitionVersion entries
- Adds filePathGenerator bundle mapping for the type
WillieRuemmele
force-pushed
the
wr/hashVersionSeparator
branch
from
August 25, 2026 21:08
e51f5e0 to
cb9bd70
Compare
…939860@ Bundle types must not have 'suffix' set — it causes calculateRelativePath to take the flat path (directoryName/basename) instead of the trimUntil path that preserves bundle subdirectory structure. This was causing retrieved files to be written flat rather than in the expected bundle directory (e.g., type/name/name.suffix-meta.xml).
…-23939860@ When a user specifies just the agent name without a version (e.g., -m "AiAgentDefinitionVersion:AgentName"), resolve it to the highest version by calling listMetadata and selecting the max version number.
Self-document the version separator convention: BotVersion uses '.' and AiAgentDefinitionVersion uses '#'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
key.split('#')inmetadataApiDeploy.tsbreaks when fullNames contain#(AiAgentDefinitionVersion usesAgentName#Nformat). Changed to split only on first#.suffixand newversionSeparatorfield for AiAgentDefinitionVersionparseAgentVersionFullNameparser,componentSetBuilderhandling, andfilePathGeneratorbundle mappingWork Item
@W-23939860@: Add '#' Version separator support to the CLI
Proof of Work
tsc --noEmit)Test plan
AiAgentDefinitionVersion:AgentName#1— should resolve correctly without key splitting errorsAiAgentDefinitionVersion:AgentName#*— should retrieve all versions