Improve how healthchecks are done - #257
Open
doanac wants to merge 3 commits into
Open
Conversation
added 3 commits
September 2, 2026 15:09
This also only logs a sampling of healthz checks to prevent swamping our logs in things like GCP with load-balancer health checks Signed-off-by: Andy Doan <doanac@qti.qualcomm.com>
Build on the /healthz logic of the previous commit to make logs cleaner for our UI code as well. Signed-off-by: Andy Doan <doanac@qti.qualcomm.com>
Signed-off-by: Andy Doan <doanac@qti.qualcomm.com>
vkhoroz
approved these changes
Sep 5, 2026
| if c.Path() != "/healthz" { | ||
| return false | ||
| } | ||
| // log once every 10 hits to now swamp our logs |
Member
There was a problem hiding this comment.
Suggested change
| // log once every 10 hits to now swamp our logs | |
| // log once every 10 hits to not swamp our logs |
Comment on lines
+65
to
+69
| if c.Path() != "/healthz" { | ||
| return false | ||
| } | ||
| // log once every 10 hits to now swamp our logs | ||
| return healthzHits.Add(1)%10 != 1 |
Member
There was a problem hiding this comment.
We might add other logic for other endpoints into this skipper later. So, I'd change the order of checks to more verbose:
Suggested change
| if c.Path() != "/healthz" { | |
| return false | |
| } | |
| // log once every 10 hits to now swamp our logs | |
| return healthzHits.Add(1)%10 != 1 | |
| if c.Path() == "/healthz" { | |
| // log once every 10 hits to not swamp our logs | |
| return healthzHits.Add(1)%10 != 1 | |
| } | |
| return false |
Or, even use a more verbose switch:
Suggested change
| if c.Path() != "/healthz" { | |
| return false | |
| } | |
| // log once every 10 hits to now swamp our logs | |
| return healthzHits.Add(1)%10 != 1 | |
| switch c.Path() { | |
| case "/healthz": | |
| // log once every 10 hits to not swamp our logs | |
| return healthzHits.Add(1)%10 != 1 | |
| } | |
| return false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you start to run our server in AWS and GCP, you'll quickly get swamped with TLS handshake error messages and /favicon page hits. This PR introduces a /healthz endpoint that logs 1 out of every 10 checks to help prevent being swamped by noise.