Repository navigation
Record request params and job arguments only when the app opts in - #120
Merged
Merged
Conversation
filter_parameters matches keys, so positional job arguments, mail delivery jobs and webhook payloads were stored and emailed as they were. The controller action and the job's class, id and queue are still recorded; record_params and record_arguments turn the rest back on. Fixes #117. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117.
0.9.0 (#115) began storing request params and job arguments with every occurrence, and emailing them. The only filter was
config.filter_parameters, which matches keys. That let these through:body:,content:),Now, by default, an occurrence records which work failed, but not its inputs:
controller(UsersController#show), andjob,job_idandqueue.config.solid_errors.record_params = trueandconfig.solid_errors.record_arguments = truerestore the 0.9.0 behaviour, still filtered byfilter_parameters.Context the app sets itself still takes precedence. The
||=that #117 relies on stays, and the README now documents it.Tests: by default, a request with private params and a job with private arguments record neither, and both tests fail without the change. The opt-in tests keep the 0.9.0 filtering and GlobalID behaviour.
This should ship as 0.9.1, with a changelog note that 0.9.0 recorded these.
🤖 Generated with Claude Code