Skip to content

Feat/reply with all via headers in sip responses#157

Open
matteolc wants to merge 5 commits into
freeswitch:masterfrom
matteolc:feat/reply-with-all-via-headers-in-SIP-responses
Open

Feat/reply with all via headers in sip responses#157
matteolc wants to merge 5 commits into
freeswitch:masterfrom
matteolc:feat/reply-with-all-via-headers-in-SIP-responses

Conversation

@matteolc

@matteolc matteolc commented Jul 11, 2022

Copy link
Copy Markdown

Some softswitches rely on Via header information in the 100 Trying response to be able to route calls internally (Sippy Softswitch for example). Without this information, softswitches sending calls to FreeSWITCH will fail to process the call because they are not able to match/route (internally) the INVITE with the 100 response received.
This behaviour may or may not be desirable and may or may not be SIP protocol complaint (it's internal spaghetti logic that could be avoided). However the end result is less interoperability in the wild.

The intent of this PR is to increase the interoperability of Sofia SIP/FreeSWITCH with a wider range of softswitches.

@freeswitch-ci-system

Copy link
Copy Markdown

@lazedo

lazedo commented Jul 11, 2022

Copy link
Copy Markdown
Contributor

duplicate of #41 ?

@matteolc

Copy link
Copy Markdown
Author

duplicate of #41 ?

Yes. Should I add a comment on #41 and close this PR? I wanted to raise some attention on this subject again (seemed like a stale PR)

@lazedo

lazedo commented Jul 11, 2022

Copy link
Copy Markdown
Contributor

leave it open. maybe @andywolk or @mjerris can find time to look at this (or #41)

@xadhoom

xadhoom commented Jul 11, 2022

Copy link
Copy Markdown

may I suggest to cleanup the patch from whitespaces fixes? makes hard spotting the real change ;)

@lazedo

lazedo commented Jul 11, 2022

Copy link
Copy Markdown
Contributor

@xadhoom check #41 , same without whitespace cleanup

@matteolc

Copy link
Copy Markdown
Author

Sure, no problem I will remove the linter auto corrections.

@freeswitch-ci-system

Copy link
Copy Markdown

@killdashnine

Copy link
Copy Markdown

Any update on this? Happy to make a new PR for this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants