Skip to content

Fix exclusion-bound target direction - #1468

Merged
Marenz merged 1 commit into
frequenz-floss:v1.x.xfrom
Marenz:fix/side-preserving-exclusion-power
Oct 7, 2026
Merged

Marenz merged 1 commit into
frequenz-floss:v1.x.xfrom
Marenz:fix/side-preserving-exclusion-power

Conversation

@Marenz

@Marenz Marenz commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Small discharge or charge requests inside an asymmetric exclusion range could snap to the nearer edge on the opposite side.

Keep the nearest valid edge when it preserves direction; otherwise fall back to zero. The allocation log now includes the final target.
Regression coverage exercises both opposite-edge fallbacks and a same-side nearest edge through ShiftingMatryoshka.calculate_target_power().

@Marenz
Marenz requested a review from a team as a code owner October 7, 2026 12:29
@Marenz
Marenz requested review from llucax and removed request for a team October 7, 2026 12:29
@github-actions github-actions Bot added part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests part:microgrid Affects the interactions with the microgrid labels Oct 7, 2026
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
@Marenz
Marenz force-pushed the fix/side-preserving-exclusion-power branch from 93495af to 6fb3a17 Compare October 7, 2026 12:37
@llucax
llucax requested a review from shsms October 7, 2026 12:51

@shsms shsms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. Are you looking for correctness issues? Can't imagine we'd see this in production, but agree that we should take this in, just in case.

@Marenz
Marenz added this pull request to the merge queue Oct 7, 2026
Merged via the queue into frequenz-floss:v1.x.x with commit ed89e21 Oct 7, 2026
9 checks passed
@Marenz
Marenz deleted the fix/side-preserving-exclusion-power branch October 7, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:docs Affects the documentation part:microgrid Affects the interactions with the microgrid part:tests Affects the unit, integration and performance (benchmarks) tests

Projects

Development

Successfully merging this pull request may close these issues.

2 participants