Repository navigation
Fix exclusion-bound target direction - #1468
Merged
Marenz merged 1 commit intoOct 7, 2026
Merged
Conversation
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Marenz
force-pushed
the
fix/side-preserving-exclusion-power
branch
from
October 7, 2026 12:37
93495af to
6fb3a17
Compare
shsms
approved these changes
Oct 7, 2026
shsms
left a comment
Contributor
There was a problem hiding this comment.
This makes sense. Are you looking for correctness issues? Can't imagine we'd see this in production, but agree that we should take this in, just in case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small discharge or charge requests inside an asymmetric exclusion range could snap to the nearer edge on the opposite side.
Keep the nearest valid edge when it preserves direction; otherwise fall back to zero. The allocation log now includes the final target.
Regression coverage exercises both opposite-edge fallbacks and a same-side nearest edge through
ShiftingMatryoshka.calculate_target_power().