You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Contains the non-WebSocket fixes extracted semantically from the former mixed #608 diff: generic streaming execution, async-enumerator cancellation/error handling, middleware behavior, schema/type-system adjustments, and focused non-WebSocket tests.
Review scope
Please review only generic streaming and middleware behavior introduced on top of #611. The GQLResponse.Data : Skippable<Output voption> contract is reviewed in #611. WebSocket transport/lifecycle and serialization are reviewed separately in #608.
Bring in the remaining non-WebSocket, non-typo changes from the
original branch on top of the response-data-skippable contract:
generic streaming/async-enumerator fixes and reformatting in
Execution.fs, Executor.fs and ObservableExtensions.fs; schema/
type-system additions and documentation in SchemaDefinitions.fs and
TypeSystem.fs; the ObjectListFilter middleware behavior change and
reformatting in MiddlewareDefinitions.fs; the ErrorMessages.fs
'indetifier' rename and the 'indicies' rename in Execution.fs/
TaskSeqFieldTests.fs (incidental identifier renames, not documentation
typo fixes); RELEASE_NOTES.md bullet-list reordering; and non-WebSocket
test additions/reformatting across DeferredTests.fs, ExecutionTests.fs,
ExecutorMiddlewareTests.fs, MutationTests.fs, Relay/ConnectionTests.fs,
LazyEnumerationExceptionTests.fs, MiddlewareTests.fs,
ObservableExtensionsTests.fs, ErrorHelpers.fs and TaskSeqFieldTests.fs.
Excludes WebSocket transport/lifecycle/serialization changes (kept for
the next commit) and typo/wording corrections (there are none in the
original diff; see the Fix streaming-related typos commit for details).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The new unconditional preflight does not follow the executable plan accurately. It stops at @defer/@stream/@live wrappers and at collection element plans, so wrapped or nested list filters still bypass request-level coercion. Conversely, it ignores Include and treats every collection argument named filter as this middleware's type, so a skipped subtree or an unrelated filter: String field can reject a valid request. Traverse wrappers and collection elements transparently, skip excluded nodes, and coerce only fields whose definition has the middleware-added nullable ObjectListFilter argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contains the non-WebSocket fixes extracted semantically from the former mixed #608 diff: generic streaming execution, async-enumerator cancellation/error handling, middleware behavior, schema/type-system adjustments, and focused non-WebSocket tests.
Review scope
Please review only generic streaming and middleware behavior introduced on top of #611. The
GQLResponse.Data : Skippable<Output voption>contract is reviewed in #611. WebSocket transport/lifecycle and serialization are reviewed separately in #608.Base contract PR: #611
WebSocket follow-up: #608
Verification
Relevant projects build successfully; the full unit suite passed (660 passed, 5 pre-existing skips).
git diff --checkis clean.