Skip to content

feat: update knative/func#32

Merged
matejvasek merged 1 commit into
masterfrom
update-go-func
Jun 8, 2026
Merged

feat: update knative/func#32
matejvasek merged 1 commit into
masterfrom
update-go-func

Conversation

@matejvasek

Copy link
Copy Markdown
Collaborator

Migrate CI workflow generation from the removed cmd/ci package to the new pkg/ci/github library API introduced in knative/func#3572. Replace viper-based global config with NewWorkflowGenerator and WorkflowConfig struct, removing the need for a mutex.

@matejvasek matejvasek requested review from gauron99 and lkingland June 8, 2026 16:05

@gauron99 gauron99 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Migrate CI workflow generation from the removed cmd/ci package
to the new pkg/ci/github library API introduced in knative/func#3572.
Replace viper-based global config with NewWorkflowGenerator and
WorkflowConfig struct, removing the need for a mutex.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Co-Authored-By: Claude <noreply@anthropic.com>
@matejvasek matejvasek merged commit 2b41c83 into master Jun 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants