fix: handle clipboard copy failures gracefully

[dsimansk]

Changes

• Fix missing catch in clipboard navigation

Per issue description:

GitHub Pages clipboard fix - Add missing .catch() on navigator.clipboard.writeText promise chain to prevent unhandled rejection if clipboard permission is denied.

@matejvasek is it that simple? :)

[twoGiants]

Keep it up and see my comment below 😸 👍

[matejvasek]

Doesn't he error happen before the promises comes to existence? I think the catch should be one level up or we should simply check if navigator.clipboard is defined.

It crashes with access navigator.clipboard.writeText before any promise is formed because navigator.clipboard does not exist.

Regardless it's definitely important to have that catch block! One never know what throws.

[matejvasek]

diff --git a/pages/index.html b/pages/index.html
index 7023eff..78753e7 100644
--- a/pages/index.html
+++ b/pages/index.html
@@ -240,6 +240,11 @@
           if (strip) {
             text = text.split('\n').map(l => l.startsWith(strip) ? l.slice(strip.length) : l).join('\n');
           }
+	  if (typeof navigator.clipboard === 'undefined') {
+            btn.classList.add('copy-error');
+            setTimeout(() => { btn.classList.remove('copy-error'); }, 1500);
+	    return
+	  }
           navigator.clipboard.writeText(text).then(() => {
             btn.classList.add('copied');
             setTimeout(() => { btn.classList.remove('copied'); }, 1500);

[matejvasek]

Hmm it appears the above is issue only if testing site under plain HTTP. In real usage with HTTPS it probably won't happen.

[twoGiants]

Can you add a screenshot? Then I don't need to manual test locally.

One nit.

Also squash commits and use claude for a nice commit message. We have a guide docs/references/commit-message-guide.md he can follow.

[dsimansk]

My bad, I chatted with Matej about sceenshots and everything and forgot to get back here.