Fix casting unmuxed-HLS sources (Nebula) to FCast and Chromecast - #3477
Open
ajcoll5 wants to merge 1 commit into
Open
Fix casting unmuxed-HLS sources (Nebula) to FCast and Chromecast#3477ajcoll5 wants to merge 1 commit into
ajcoll5 wants to merge 1 commit into
Conversation
…urces Unmuxed video+audio sources that point at the same HLS manifest (e.g. Nebula) crashed FCast casting with a ClassCastException. Chromecast also broken on the same source due to castProxiedHls resolving playlist-relative URLs against the pre-redirect request URL and dropping the EXT-X-MAP init segment.
Zvonimir-FUTO
added
Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nebula gives video and audio as two sources that are actually the same HLS manifest, which castIfAvailable didn't have a path for - causing an "JSHLSManifestSource" error. Fixing that showed two bugs in castProxiedHls on Chromecast. It resolved playlist-relative URLs against the pre-redirect URL instead of the actual response URL (Nebula's manifest 302s to a different host), and it dropped the EXT-X-MAP init segment when rebuilding the proxied playlist, breaking fMP4 playback.
Fixes #3239 .
Tested on a Pixel 10 casting Nebula video to both FCast receiver and Chromecast - Nebula videos play correctly on both now. Performed random tests of other sources - they continue to work comparatively to an unmodified version of Grayjay.