Skip to content

[WIP] Fail tests before run if "await" is missing - #1358

Open
sipayRT wants to merge 2 commits into
masterfrom
sp.missing-await-preflight
Open

sipayRT wants to merge 2 commits into
masterfrom
sp.missing-await-preflight

Conversation

@sipayRT

@sipayRT sipayRT commented Nov 6, 2026

Copy link
Copy Markdown
Member

No description provided.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T15:59:35.525957Z 750efef PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pkg-pr-new

pkg-pr-new Bot commented Nov 6, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/gemini-testing/testplane@1358

commit: 750efef

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

✅ Testplane browser-env run succeed

Report

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

✅ Testplane E2E run succeed

Report

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 750efefdb2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

consume(state, arg, true);
});
const label = name ?? node.expression.getText(this.source);
if (returnsPromise(this.checker, node)) return this.promise(node, label, state);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Transfer the receiver obligation for chained custom commands

When an element custom command is registered outside the analyzed callback (for example, by a plugin), await browser.$('a').custom() falls through to this type-based handling even when custom() has a declared promise return type. Unlike the known-command branch, this path never consumes the receiver's pending $ promise, so awaiting the custom command still produces a missing-await diagnostic for $. Since the check is enabled by default, this rejects valid WDIO command chains and prevents the entire collection from running. Transfer the pending receiver obligation into the custom command's promise for recognized browser/element chains; splitting the same code into const el = await browser.$('a'); await el.custom() currently passes.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant