Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
✅ Testplane browser-env run succeed
|
✅ Testplane E2E run succeed
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 750efefdb2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| consume(state, arg, true); | ||
| }); | ||
| const label = name ?? node.expression.getText(this.source); | ||
| if (returnsPromise(this.checker, node)) return this.promise(node, label, state); |
There was a problem hiding this comment.
Transfer the receiver obligation for chained custom commands
When an element custom command is registered outside the analyzed callback (for example, by a plugin), await browser.$('a').custom() falls through to this type-based handling even when custom() has a declared promise return type. Unlike the known-command branch, this path never consumes the receiver's pending $ promise, so awaiting the custom command still produces a missing-await diagnostic for $. Since the check is enabled by default, this rejects valid WDIO command chains and prevents the entire collection from running. Transfer the pending receiver obligation into the custom command's promise for recognized browser/element chains; splitting the same code into const el = await browser.$('a'); await el.custom() currently passes.
Useful? React with 👍 / 👎.
No description provided.