Skip to content

fix: prevent test directives from leaking across files - #1359

Merged
sonic16x merged 2 commits into
gemini-testing:masterfrom
vladislav805:fix/file-scoped-directives
Nov 9, 2026
Merged

sonic16x merged 2 commits into
gemini-testing:masterfrom
vladislav805:fix/file-scoped-directives

Conversation

@vladislav805

Copy link
Copy Markdown
Contributor

A directive without a following test or suite remains pending after its file is parsed. It can then affect tests in another file, making test selection and settings depend on file discovery order.

Validate pending directives at each file boundary and report the source file when an unused directive remains. Valid directives continue to apply to the next test or suite in the same file.

Regression tests cover skip, only, also, timeouts, browser versions, custom plugin controllers, valid declarations, hooks, empty files, and global settings.

Validation:

  • 548 test-reader and worker parser tests passed.
  • Build, type checks, and lint passed.
  • The full unit suite encounters existing WebSocket failures with EADDRINUSE on ports 50123 and 50124. The port 50123 failures also reproduce on the unchanged baseline.

Related: INFRADUTY-31342

@pkg-pr-new

pkg-pr-new Bot commented Nov 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/gemini-testing/testplane@1359

commit: 6cf5299

@sonic16x
sonic16x merged commit 0201179 into gemini-testing:master Nov 9, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants