Repository navigation
fix: prevent test directives from leaking across files - #1359
Merged
sonic16x merged 2 commits intoNov 9, 2026
Merged
Conversation
commit: |
sonic16x
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A directive without a following test or suite remains pending after its file is parsed. It can then affect tests in another file, making test selection and settings depend on file discovery order.
Validate pending directives at each file boundary and report the source file when an unused directive remains. Valid directives continue to apply to the next test or suite in the same file.
Regression tests cover skip, only, also, timeouts, browser versions, custom plugin controllers, valid declarations, hooks, empty files, and global settings.
Validation:
Related: INFRADUTY-31342