Skip to content

fix: parse each url of multi-layer background when waiting for static to load - #1360

Merged
KuznetsovRoman merged 1 commit into
masterfrom
TESTPLANE-1154.multi_layer_bg_img
Nov 10, 2026
Merged

KuznetsovRoman merged 1 commit into
masterfrom
TESTPLANE-1154.multi_layer_bg_img

Conversation

@KuznetsovRoman

Copy link
Copy Markdown
Member

waitForStaticToLoad treated a whole CSS value like 'url("a.png"), url("b.png")' as a single resource url, so it waited for a non-existent resource until timeout.

Now every url(...) in a CSS value is extracted separately, and resources that failed to load (no performance entry) settle the wait via image load/error events instead of hanging until timeout.

var urlMatch: RegExpExecArray | null;

while ((urlMatch = cssUrlRegExp.exec(cssValue))) {
var resourceUrl = (urlMatch[1] || urlMatch[2] || urlMatch[3] || "").replace(/\\(.)/g, "$1");

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • urlMatch[1] matches url("a.png")
  • urlMatch[2] matches url('a.png')
  • urlMatch[3] matches url(a.png)

@github-actions

Copy link
Copy Markdown

✅ Testplane browser-env run succeed

Report

@pkg-pr-new

pkg-pr-new Bot commented Nov 10, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/gemini-testing/testplane@1360

commit: 4e670a4

@github-actions

Copy link
Copy Markdown

✅ Testplane E2E run succeed

Report

@KuznetsovRoman
KuznetsovRoman merged commit 9734278 into master Nov 10, 2026
9 checks passed
@KuznetsovRoman
KuznetsovRoman deleted the TESTPLANE-1154.multi_layer_bg_img branch November 10, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants