Repository navigation
fix: parse each url of multi-layer background when waiting for static to load - #1360
Merged
Merged
Conversation
KuznetsovRoman
commented
Nov 10, 2026
| var urlMatch: RegExpExecArray | null; | ||
|
|
||
| while ((urlMatch = cssUrlRegExp.exec(cssValue))) { | ||
| var resourceUrl = (urlMatch[1] || urlMatch[2] || urlMatch[3] || "").replace(/\\(.)/g, "$1"); |
Member
Author
There was a problem hiding this comment.
urlMatch[1]matchesurl("a.png")urlMatch[2]matchesurl('a.png')urlMatch[3]matchesurl(a.png)
✅ Testplane browser-env run succeed
|
commit: |
✅ Testplane E2E run succeed
|
sonic16x
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waitForStaticToLoad treated a whole CSS value like 'url("a.png"), url("b.png")' as a single resource url, so it waited for a non-existent resource until timeout.
Now every url(...) in a CSS value is extracted separately, and resources that failed to load (no performance entry) settle the wait via image load/error events instead of hanging until timeout.