Conversation
… io.yaml ibm-granite/granitelib-core-r1.0 PR generative-computing#46 (merged 2026-10-05, commit c4b4fc6ec4fa05b6c8f02b25ac8822da085962b5) drops the colon from the requirement-check aLoRA instruction (`<requirements>: {requirement}` -> `<requirements> {requirement}`), so the invocation sequence now survives tokenisation and the adapter activates as published. The pin covers all three core adapter functions (context-attribution, requirement-check, uncertainty); only requirement-check's files changed between the old and new revisions. Removes the strict xfail from test_requirement_check_adapter_moves_score, which needs a GPU and is skipped locally. Closes generative-computing#1699, generative-computing#1679. Assisted-by: Claude Code Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
|
GPU verification done on BlueVela (LSF, job 104708, 1×H100, `p5-r32-n3`): ``` 5 passed, 2 xfailed, 0 failed in 65.12s The two |
Two mechanical review comments on PR generative-computing#1706 (code-review panel): the schema-migrations tutorial's sample output and the uncertainty Ollama build script still showed the old d0a2a96a pin after the catalog bump. Assisted-by: Claude Code Signed-off-by: Nigel Jones <jonesn@uk.ibm.com>
What this fixes
The
requirement-checkaLoRA onLocalHFBackendnever activated: the publishedio.yamlinstruction started<requirements>: {requirement}, and the Granite tokeniser merges>:into one token, so the declared invocation sequence never appeared in the prompt (#1679). The activation guard added in #1685 correctly left the adapter off in that case, but it meant callers who explicitly registered the aLoRA got base-model answers plus a one-time warning.ibm-granite/granitelib-core-r1.0PR #46 (merged 2026-10-05, commitc4b4fc6ec4fa05b6c8f02b25ac8822da085962b5) drops the colon (<requirements> {requirement}), fixing the tokenisation. This PR bumps_CORE_R1_SHAinmellea/backends/adapters/catalog.pyto that revision and removes the strictxfailfromtest_requirement_check_adapter_moves_score. Two other references to the old pin (a docs tutorial's sample output, the uncertainty Ollama build script) are updated to match.Only the requirement-check files changed between the old pin (
d0a2a96a) and the new one — context-attribution and uncertainty, which share_CORE_R1_SHA, are untouched.Testing
test_requirement_check_adapter_moves_score,test_check_certainty_adapter_moves_score, andtest/stdlib/components/intrinsic/test_core.py's qualitative suite — 5 passed, 2 pre-existing/unrelated xfails, 0 failures.test_run_transformers[requirement_check_alora]passes against the new pin — the canned fixture's expected direction still holds.uv run pytest test/ -m "not qualitative": 4758 passed, 0 failed, 20 skipped, 1 xfailed, 3 xpassed — all pre-existing/unrelated.ruff format --check,ruff check,mypy: clean.Scope note
This fixes activation only.
requirement-check's catalog entry has noadapter_typesrestriction, so once the aLoRA activates it becomes the default path forrequirement_check(). Whether the aLoRA's verdict quality is good enough for that default is tracked separately in #1707 and intentionally out of scope here.Fixes #1699
Fixes #1679