Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
Fixes mobile follow-up composer footer visibility by scoping collapse styles to unexpanded composers.
Changes:
- Guards the footer-collapse selector with the expanded-state attribute.
- Adds a regression assertion for the corrected selector.
File summaries
| File | Summary |
|---|---|
apps/app/src/app.css.test.ts |
Verifies the guarded selector. |
apps/app/src/app.css |
Preserves the footer when expanded. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
In #3601, the compact follow-up composer container collapsed its status footer with an unconditional descendant selector. On iOS, React correctly marked a focused composer with
data-follow-up-composer-expandedand rendered the environment and context controls, but the container rule still forced that footer to zero height and opacity.What changed
Scope the existing footer-collapse rule to follow-up composers without
data-follow-up-composer-expanded, matching the neighboring compact composer rules. Add a CSS regression assertion that requires the expanded-state guard and rejects the former broad selector.How you verified
pnpm exec turbo run test --filter=@bb/app -- --run src/app.css.test.ts src/components/promptbox/FollowUpPromptBox.test.tsx(46 tests passed)pnpm exec turbo run build --filter=@bb/appgit diff origin/main...HEAD --checkFixes #3601