Repository navigation
Add an opt-in PDF download opener - #3700
Closed
banjerluke wants to merge 6 commits into
Closed
banjerluke wants to merge 6 commits into
banjerluke wants to merge 6 commits into
Conversation
lukes-clanker
Bot
force-pushed
the
feat/pdf-download-opener
branch
from
September 22, 2026 23:32
5a23b15 to
277578e
Compare
lukes-clanker
Bot
force-pushed
the
feat/pdf-download-opener
branch
from
September 29, 2026 00:13
277578e to
90a922a
Compare
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
On my Android 13 eInk tablet (Boox Note Max), PDF links would open a side panel browser but wouldn't display, I assume due to platform limitations. The ideal flow on that device is to download the PDF, which sends it right into the Notes app where I can review and/or annotate it. (Re-submission of #2689)
What was wrong
The file-opener system could select the built-in preview or a plugin viewer, but had no download action. Users whose browsers could not display PDFs lacked a persistent preference or one-off action to download them instead.
What changed
.pdffiles under Settings → File openers, preserving existing default opener behavior.This is an app-only change. It adds no server endpoint or contract changes, host-daemon protocol changes, or public Plugin SDK surface.
How you verified
pnpm exec turbo run typecheck --filter=@bb/apppnpm exec turbo run test --filter=@bb/app -- file-download useThreadFileTabs FileOpenersSettingsSection plugin-slot-resolversgit diff --check origin/main...HEADpassed.