fix(compare): skip a provider whose discovery fails instead of exiting - #1643
Merged
Merged
Conversation
compare's self-correction scan called discoverSessions() directly, so a provider that throws on purpose (Warp without Full Disk Access, a busy or locked SQLite store) killed the whole command with exit 1. The desktop Compare section then showed an error on every poll. Route it, the TUI compare and the dashboard provider probe through safeDiscoverSessions like every other command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compare --format jsoncalleddiscoverSessions()directly for its self-correction scan. Since 0.9.25 some providers throw on purpose so a run can be marked incomplete (Warp without Full Disk Access, busy or locked SQLite stores). Every other command goes throughsafeDiscoverSessions, which warns and skips the provider; compare didn't, so one blocked provider exited the whole command with 1.In the desktop app that left the Compare section on a permanent error panel, and every failure fell back to a second cold spawn. Telemetry shows the compare
nonzeroerrors only on desktop 0.9.25.The TUI compare and the dashboard provider probe had the same raw call and get the same one-line change.
Checked: with an unreadable Warp database, main exits 1 with an uncaught
macOS blocked accesserror; this branch exits 0 with the "skipped warp" warning. tsc clean, compare CLI tests pass.