fix(ci): replace deprecated macos-13 runner with ubuntu-latest for darwin-x64#1039
Merged
Conversation
…rwin-x64 macos-13 (Intel) runners are no longer available on GitHub Actions, causing the darwin-x64 build to queue indefinitely. Since this target is cross-compiled via fossilize and has can-test:false (can't execute an x64 binary on arm64 macOS anyway), ubuntu-latest is the correct choice — matching all other cross-compiled targets.
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 4297 uncovered lines. Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
darwin-x64build-binary job usesmacos-13(Intel) runners which are no longer available on GitHub Actions, causing the job to queue indefinitely on every main/release push.Fix
Switch
darwin-x64frommacos-13toubuntu-latest. This target is already cross-compiled via fossilize and hascan-test: false(can't execute an x64 binary on arm64 macOS anyway), so it matches all other cross-compiled targets.The only darwin target that needs a native macOS runner is
darwin-arm64(macos-latest) for V8 code cache and smoke testing.