fix(event): Handle issue short ID as second positional arg - #1420
Merged
jared-outpost[bot] merged 2 commits intoAug 19, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 932e569. Configure here.
Member
|
Jared, feel free to merge if the patch looks good. If not push fixes you see fit and then merge |
When an issue short ID was passed as the second positional arg with an explicit `org/project` target, resolveIssueShortcut only read the org for `org-all` targets, so the specified org was dropped and resolution fell back to auto-detection. Read the org from `explicit` targets too, matching resolveIssueIdShortcut. Adds a regression test.
github-actions
Bot
added
risk: high
Contributor
|
patch looks good — the bugbot finding was real (explicit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
sentry event viewwould fail with aResolutionErrorwhen an issue short ID (e.g.,PRODUCTION-RCP-API-A9R) was passed as the second positional argument (e.g.,sentry event view <org>/<project> PRODUCTION-RCP-API-A9R).The root cause was that
parsePositionalArgsinpackages/cli/src/commands/event/view.tscorrectly checkedlooksLikeIssueShortId(first)for the first argument but lacked a corresponding check forlooksLikeIssueShortId(second).The fix adds this missing check. Now, when an issue short ID is detected as the second argument,
parsePositionalArgsreturns{ eventId: LATEST_EVENT_SENTINEL, targetArg: first, issueShortId: second }, allowing the command to correctly resolve the latest event for that issue, preventing the misleading "is not a valid ID" error.Fixes CLI-1EJ