test(github): Add push permission outcome evals#919
Open
sentry-junior[bot] wants to merge 2 commits into
Open
Conversation
Co-Authored-By: immutable dcramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6576c3d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add end-to-end eval coverage for the two permission-result histories that can make a successful push look denied.
Simulated Outcomes
A local-only fixture now models both a genuine first HTTP 403 followed by a successful retry and a stale HTTP 403 returned after the remote mutation applied. Each eval requires Junior to reconcile remote state before retrying or reporting the final outcome.
The deterministic fixture scripts and eval package typecheck pass. The model eval run is currently blocked locally because the eval database at
127.0.0.1:54322is unavailable.Requested by immutable dcramer via Junior.
--
View Junior Session in Sentry