fix(slack): Complete processing reactions on reaction-only turns#937
Merged
Conversation
Reaction-only / no-reply turns left the processing emoji stuck when post-delivery work failed before onTurnCompleted, and complete() skipped the done emoji if removing the processing reaction failed. Always notify turn completion after delivery acceptance, and always attempt remove+done independently. Also cover the lifecycle in unit/integration tests and the existing reaction-only eval (assert processing emoji removed and done added). Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: David Cramer <david@sentry.io>
vi.mock factories are hoisted above const declarations, so the outbound reaction spies need vi.hoisted to avoid ReferenceError under CI.
dcramer
marked this pull request as ready for review
July 17, 2026 05:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reaction-only / no-reply turns (e.g. "give me a heart reaction") were leaving the processing emoji stuck and skipping the completed emoji.
Processing reaction lifecycle
complete()used to early-return when removing the processing reaction failed, so the done emoji never got added. Remove and done are now independent steps.Post-delivery completion
After Slack accepted a no-reply / reaction-only delivery, post-delivery errors could skip
onTurnCompleted, so the turn ranstopAll()(remove only) instead ofcompleteAll()(remove + done). Delivery acceptance now always notifies turn completion (idempotently).Coverage
Verified: unit
processing-reaction.test.ts(3/3), typecheck clean. Integration and evals not run in this environment (no local Postgres/docker / sandbox gateway).Requested by David Cramer via Junior.
--
View Junior Session