Skip to content

Fix falsy JSON params matching - #843

Open
bulbiyy wants to merge 1 commit into
getsentry:masterfrom
bulbiyy:master
Open

bulbiyy wants to merge 1 commit into
getsentry:masterfrom
bulbiyy:master

Conversation

@bulbiyy

@bulbiyy bulbiyy commented Nov 1, 2026

Copy link
Copy Markdown

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other

Description

Fix json_params_matcher so falsy top-level JSON values (0, False, and "") are compared as provided instead of being replaced with {}. Add tests confirming those values match correctly and that different values do not match.

Related Issues

PR checklist

Before submitting this pull request, I have done the following:

Added/updated tests?

Current repository has 100% test coverage.

  • Yes
  • No, and this is why:
  • I need help with writing tests

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@bulbiyy
bulbiyy requested a review from markstory as a code owner November 1, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants