Skip to content

ci(release): Bump craft to 3.9.0 and update config - #844

Open
sentry-junior[bot] wants to merge 3 commits into
masterfrom
ci/bump-craft-3.9.0
Open

sentry-junior[bot] wants to merge 3 commits into
masterfrom
ci/bump-craft-3.9.0

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Bumps the pinned getsentry/craft action from 2.19.0 (c6e2f049, comment said v2) to 3.9.0 (2e29b081).

Craft's "Check release blockers" step used to call the async run-cancel API and then exit 0, so the job kept going and could still open a getsentry/publish issue while release-blocker issues were open (example in getsentry/symbolic). getsentry/craft#956 fixed that, and the fix shipped in craft 3.9.0. This is the same change as getsentry/symbolic#1134.

minVersion is 0.21.0, so craft keeps using scripts/bump-version.sh and the 3.0 automatic version bumping change doesn't apply. There's no top-level changelog.includePaths/unownedPaths and no nuget target. I ran craft 3.9.0's craft prepare 99.0.0 --dry-run --no-input --no-push on the default branch before this change. It passed and bumped setup.py as expected.

There are no open release-blocker issues here, so nothing stops the next release. From now on, any open release-blocker issue will stop the release.

Config changes: minVersion "0.21.0" → "3.9.0". A minVersion of 2.21.0 or higher makes craft switch from running scripts/bump-version.sh to automatic target bumping. A minVersion of 2.14.0 or higher changes the default versioning policy from manual to auto. To keep releases the same, this adds preReleaseCommand: bash scripts/bump-version.sh and versioning.policy: manual. craft 3.9.0's prepare 99.0.0 --dry-run gave the same result before and after this change: setup.py was bumped.

via @BYK.

--

View Session in Sentry

Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
@sentry-junior
sentry-junior Bot requested a review from markstory as a code owner November 3, 2026 21:00
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
@codecov

codecov Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.91%. Comparing base (aae1d47) to head (ca1c7e7).
⚠️ Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
+ Coverage   99.84%   99.91%   +0.06%     
==========================================
  Files           9        9              
  Lines        3295     3407     +112     
==========================================
+ Hits         3290     3404     +114     
+ Misses          5        3       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sentry-junior sentry-junior Bot changed the title ci(release): Bump getsentry/craft to 3.9.0 ci(release): Bump craft to 3.9.0 and update config Nov 3, 2026
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants