Repository navigation
ci(release): Bump craft to 3.9.0 and update config - #844
Open
sentry-junior[bot] wants to merge 3 commits into
Open
sentry-junior[bot] wants to merge 3 commits into
sentry-junior[bot] wants to merge 3 commits into
Conversation
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #844 +/- ##
==========================================
+ Coverage 99.84% 99.91% +0.06%
==========================================
Files 9 9
Lines 3295 3407 +112
==========================================
+ Hits 3290 3404 +114
+ Misses 5 3 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pbhandari
approved these changes
Nov 16, 2026
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the pinned
getsentry/craftaction from 2.19.0 (c6e2f049, comment saidv2) to 3.9.0 (2e29b081).Craft's "Check release blockers" step used to call the async run-cancel API and then exit 0, so the job kept going and could still open a getsentry/publish issue while
release-blockerissues were open (example in getsentry/symbolic). getsentry/craft#956 fixed that, and the fix shipped in craft 3.9.0. This is the same change as getsentry/symbolic#1134.minVersionis 0.21.0, so craft keeps usingscripts/bump-version.shand the 3.0 automatic version bumping change doesn't apply. There's no top-levelchangelog.includePaths/unownedPathsand no nuget target. I ran craft 3.9.0'scraft prepare 99.0.0 --dry-run --no-input --no-pushon the default branch before this change. It passed and bumpedsetup.pyas expected.There are no open
release-blockerissues here, so nothing stops the next release. From now on, any openrelease-blockerissue will stop the release.Config changes:
minVersion"0.21.0" → "3.9.0". A minVersion of 2.21.0 or higher makes craft switch from runningscripts/bump-version.shto automatic target bumping. A minVersion of 2.14.0 or higher changes the default versioning policy frommanualtoauto. To keep releases the same, this addspreReleaseCommand: bash scripts/bump-version.shandversioning.policy: manual. craft 3.9.0'sprepare 99.0.0 --dry-rungave the same result before and after this change:setup.pywas bumped.via @BYK.
--
View Session in Sentry