Repository navigation
Conversation
Requests let through by an add_passthru prefix or regex went to the real adapter without being added to responses.calls, while requests matched by a PassthroughResponse were recorded. Record them the same way. Fixes getsentry#755
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
okay so this is a bug fix. requests let through by
add_passthru(a URL prefix or a regex) went to the real adapter but were never added toresponses.calls, soresponses.callsandassert_call_count()didn't see them. requests matched by aPassthroughResponsewere already recorded. this records theadd_passthruones the same way.I added call assertions to the existing
test_passthruandtest_passthru_regex. both failed before the change (2 calls instead of 3 and 4) and pass now. rantoxlocally (py311 through py315, mypy, precom), all passing.left alone on purpose:
response_callbackstill isn't applied toadd_passthruresponses and a connection error from the real request still isn't recorded, same as before.Related Issues
PR checklist
Before submitting this pull request, I have done the following:
toxandpre-commitchecks locallyAdded/updated tests?