Skip to content

feat: Add Linux riscv64 support - #3396

Open
Xeonacid wants to merge 1 commit into
getsentry:masterfrom
Xeonacid:feat/linux-riscv64
Open

feat: Add Linux riscv64 support#3396
Xeonacid wants to merge 1 commit into
getsentry:masterfrom
Xeonacid:feat/linux-riscv64

Conversation

@Xeonacid

Copy link
Copy Markdown

Description

Build and distribute sentry-cli for Linux riscv64 across GitHub releases, npm, PyPI, and Homebrew. Leave package-lock.json unchanged because @sentry/cli-linux-riscv64 is not published yet.

Issues

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Build and distribute sentry-cli for Linux riscv64 across GitHub
releases, npm, PyPI, and Homebrew. Leave package-lock.json unchanged
because @sentry/cli-linux-riscv64 is not published yet.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5f19c03. Configure here.

Comment thread package.json
"@sentry/cli-linux-arm": "3.6.2",
"@sentry/cli-linux-arm64": "3.6.2",
"@sentry/cli-linux-i686": "3.6.2",
"@sentry/cli-linux-riscv64": "3.6.2",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lockfile missing new optional dependency

Medium Severity

@sentry/cli-linux-riscv64 was added to optionalDependencies without a matching package-lock.json entry. npm ci requires those files to stay in sync and already special-cases this mismatch on release branches, so Test Node and other npm ci --ignore-scripts jobs can fail until the lockfile includes the package.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 5f19c03. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant