feat(nuxt): Add _experimental.useDiagnosticsChannelInjection#22323
Open
s1gr1d wants to merge 6 commits into
Open
feat(nuxt): Add _experimental.useDiagnosticsChannelInjection#22323s1gr1d wants to merge 6 commits into
_experimental.useDiagnosticsChannelInjection#22323s1gr1d wants to merge 6 commits into
Conversation
s1gr1d
requested review from
JPeer264,
chargome,
mydea and
nicohrubec
and removed request for
a team
July 16, 2026 11:58
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
# Conflicts: # dev-packages/e2e-tests/test-applications/nuxt-4-orchestrion/package.json
chargome
approved these changes
Jul 17, 2026
|
|
||
| // ioredis requires this CommonJS helper to be bundled with it. Leaving it | ||
| // external makes Nitro resolve the default export as a namespace object. | ||
| const IORedisDependencies = ['standard-as-callback']; |
Member
There was a problem hiding this comment.
q: This will likely fail for all nitro based frameworks I guess? Maybe we can move this to server utils at some point so we can make this reusable if we run into more of these things.
| const nuxtMajor = parseInt((nuxt as unknown as { _version: string })._version?.split('.')[0] ?? '3', 10); | ||
| const isMinNuxtV4 = nuxtMajor >= 4; | ||
|
|
||
| if (serverConfigFile && moduleOptions._experimental?.useDiagnosticsChannelInjection) { |
Member
There was a problem hiding this comment.
nit: This check could be moved to the block below.
| _experimental: { | ||
| useDiagnosticsChannelInjection: true, | ||
| }, | ||
| autoInjectServerSentry: 'top-level-import', |
Member
There was a problem hiding this comment.
q: Is the plan to make this the default then?
JPeer264
approved these changes
Jul 17, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
LGTM. + charlies additions.
Tests are failing, but I guess after a rebase these should pass.
| return; | ||
| } | ||
|
|
||
| if (!nitroConfig.rollupConfig) { |
Member
There was a problem hiding this comment.
super-l: That is one of the view moments while engineering where the following could be used (I always wanted to use it, but almost never had the chance) - you also have it later in the code:
nitroConfig.rollupConfig ??= {}
Co-authored-by: Charly Gomez <charly.gomez1310@gmail.com>
nicohrubec
approved these changes
Jul 17, 2026
| /** | ||
| * Experimental build-time options that may change or be removed without notice. | ||
| */ | ||
| _experimental?: { |
Member
There was a problem hiding this comment.
q: this will go away again in v11?
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
useDiagnosticsChannelInjectionoption and updates the E2E test.When using
_experimental.useDiagnosticsChannelInjection, users also need to do those steps:Sentry.experimentalUseDiagnosticsChannelInjection()just beforeSentry.init()--import ./.output/server/sentry.server.config.mjsfrom yourstartscriptsentry.autoInjectServerSentry: 'top-level-import'innuxt.config.tsso Sentry's server configuration is automatically importedcloses #22348