feat(wasm): patch non-streaming load paths & dedupe web worker patching - #23767
Open
d2anamaria wants to merge 2 commits into
Open
feat(wasm): patch non-streaming load paths & dedupe web worker patching#23767d2anamaria wants to merge 2 commits into
d2anamaria wants to merge 2 commits into
Conversation
d2anamaria
marked this pull request as draft
August 31, 2026 12:44
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 583b876. Configure here.
- Patch `Response.prototype.arrayBuffer` and `bytes` to tag wasm buffers with `response.url` in a `WeakMap` - Hook `WebAssembly.instantiate` and `compile` to use tagged URL to register module - Skip registration when `instantiate` receives an already-compiled `WebAssembly.Module` - Split `patchWebAssembly` into response, non-streaming, and streaming setup; guard non-streaming with `nonStreamingPatched` - Add `patchWebAssembly.test.ts` for fetch → arrayBuffer → instantiate/compile - Extend `webworker.test.ts` to restore patched globals and assert `instantiate` is hooked
andreiborza
force-pushed
the
ana/feat/wasm-non-streaming
branch
from
August 31, 2026 22:15
3a55a63 to
99a2a60
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register wasm modules when apps load via
fetch → arrayBuffer → WebAssembly.instantiate/compile, not only streaming APIs.Response.prototype.arrayBufferandbytesso wasm buffers remember their fetch URLWebAssembly.instantiateandcompileto register modules after byte-based loadspatchWebAssembly(register)for workers so non-streaming registration works there tooImplementation
patchWasmResponse.tstags wasm buffers in aWeakMapwhen read from a wasm-likeResponse;getWasmSourceUrl()resolves them at instantiate/compile timepatchWebAssembly()orchestrates response patching, non-streaming hooks, then streaming hooks (unchanged behavior)instantiatereceives an already-compiledWebAssembly.ModulepatchWebAssembly((module, url) => registerModuleAndForward(...))instead of duplicating streaming patches inindex.ts