feat(remix): Register a route provider outside the tracing integration - #23791
Draft
logaretm wants to merge 1 commit into
Draft
feat(remix): Register a route provider outside the tracing integration#23791logaretm wants to merge 1 commit into
logaretm wants to merge 1 commit into
Conversation
`maybeParameterizeRemixRoute` is already a pure matcher over the route manifest the Vite plugin injects at build time, it was just only reachable from the pageload and navigation instrumentation. Registered from `init()` rather than a tracing integration, because the manifest is on the global object before `Sentry.init` runs. Route parameterization no longer depends on tracing being enabled.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers a route provider for Remix from the route manifest the Vite plugin already injects at build time.
maybeParameterizeRemixRoutewas already a pure matcher over that manifest, it was just only reachable from the pageload and navigation instrumentation. Registered frominit()rather than a tracing integration, so route parameterization no longer depends on tracing being enabled.Same shape as #23552, and simpler: Remix has one manifest and no
basePathasymmetry.Part of #23556