Repository navigation
fix(v10/replay): Apply attribute masking to breadcrumb messages - #25697
Merged
nicohrubec merged 2 commits intoOct 24, 2026
Merged
Conversation
Backport of: #25180 Co-Authored-By: GPT-6 <codex@openai.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0b13f6e. Configure here.
| sdk.replay['_handleKeyboardEvent'](event); | ||
| } else { | ||
| sdk.domHandler({ name, event }); | ||
| } |
There was a problem hiding this comment.
Conditionals inside parameterized tests
Low Severity
These parameterized cases branch with if instead of splitting the paths. One case chooses the keydown versus click/keypress entry point, and another only adds sentry-unmask when unmask is present. This was flagged because the review guidelines ask to split conditionals in a test into separate cases.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 0b13f6e. Configure here.
nicohrubec
marked this pull request as ready for review
October 23, 2026 10:43
nicohrubec
requested review from
Lms24 and
logaretm
and removed request for
a team
October 23, 2026 10:43
Contributor
size-limit report 📦
|
logaretm
approved these changes
Oct 24, 2026
nicohrubec
deleted the
feat/v10-backport-25180-replay-breadcrumb-masking
branch
October 24, 2026 07:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #25180