ref!: sentry_value-based attachments - #1974
Open
jpnurmi wants to merge 7 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1974 +/- ##
==========================================
+ Coverage 74.31% 74.67% +0.36%
==========================================
Files 104 104
Lines 25738 26171 +433
Branches 4648 4722 +74
==========================================
+ Hits 19126 19543 +417
+ Misses 5305 5297 -8
- Partials 1307 1331 +24 🚀 New features to boost your workflow:
|
jpnurmi
force-pushed
the
jpnurmi/ref/attachments
branch
from
August 11, 2026 20:01
4ecd0c8 to
7cfebae
Compare
jpnurmi
force-pushed
the
jpnurmi/ref/attachments
branch
from
August 12, 2026 06:33
7cfebae to
ed216c7
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Allow callers with borrowed path strings to obtain the final path component without allocating a sentry_path_t. This prepares value-based attachment properties, which expose borrowed strings.
jpnurmi
force-pushed
the
jpnurmi/ref/attachments
branch
from
August 17, 2026 07:51
77576ea to
8349c66
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
jpnurmi
force-pushed
the
jpnurmi/ref/attachments
branch
from
August 17, 2026 09:40
8349c66 to
c7f80db
Compare
jpnurmi
force-pushed
the
jpnurmi/ref/attachments
branch
from
August 17, 2026 10:37
c7f80db to
b901758
Compare
This was referenced Aug 17, 2026
jpnurmi
changed the title
Use each byte attachment's existing UUID as its run-directory name in both native and Crashpad. This gives the attachment a stable path before scope storage freezes its metadata and lets later consumers recover the same location without mutating the attachment. Keep the original filename as the basename so crash uploads preserve the user-facing attachment name.
Derive backend byte attachment paths from the attachment UUID without storing the path in attachment metadata. Resolve the same path when native serializes crash attachments and when Crashpad removes them.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a6dd4ac. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
BREAKING CHANGE
Attachment APIs now use
sentry_value_tandsentry_uuid_tinstead ofsentry_attachment_t *.Scope data is moving to fine-grained read/write locking (#1877) to allow concurrent readers. A read-locked getter cannot safely return a borrowed
sentry_attachment_tpointer because a writer may remove and free the attachment as soon as the read lock is released, crashing a potential concurrent reader.Represent attachments and attachment collections as refcounted
sentry_value_tobjects. A getter can retain the value under the read lock and return an owned reference that remains valid after unlocking.Configure attachments before insertion and freeze them once added. Use UUIDs for removal, and retain byte values while envelopes borrow their payload to avoid copying attachment data.
See also:
Resolves: #1945