feat: add on_crashed_last_run callback - #1985
Open
jpnurmi wants to merge 17 commits into
Open
Conversation
Have the native crash daemon adopt the application's existing .run instead of creating a second unrelated .run, and store daemon logs, minidumps, crash envelopes, and signal-handler scratch files within that .run. Protect daemon-owned work with a dedicated `.run.daemon.lock` so old-run processing waits for completion. Keep retry cache and external storage database-global, and leave crashed runs for normal next-launch cleanup.
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1985 +/- ##
==========================================
+ Coverage 74.41% 74.43% +0.02%
==========================================
Files 104 104
Lines 25913 26077 +164
Branches 4691 4732 +41
==========================================
+ Hits 19282 19411 +129
- Misses 5299 5322 +23
- Partials 1332 1344 +12 🚀 New features to boost your workflow:
|
jpnurmi
force-pushed
the
jpnurmi/feat/on-crashed-last-run
branch
from
August 12, 2026 19:59
386c7cb to
e48d967
Compare
jpnurmi
force-pushed
the
jpnurmi/feat/on-crashed-last-run
branch
from
August 13, 2026 12:11
93dd083 to
4fabb41
Compare
Invoke the callback during startup for envelopes associated with crashes in previous runs across the in-process, Breakpad, Crashpad, and native backends. Retain the native daemon's dedicated crash envelope in the application run as callback-only state, separate from transport queue dumps, so successfully delivered crashes are not sent again.
jpnurmi
force-pushed
the
jpnurmi/feat/on-crashed-last-run
branch
from
August 14, 2026 08:34
12f1eff to
bf26eaf
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bf26eaf. Configure here.
This was referenced Aug 14, 2026
mujacica
approved these changes
Aug 17, 2026
…shed-last-run # Conflicts: # CHANGELOG.md # src/backends/native/sentry_crash_daemon.c # src/sentry_database.c # src/sentry_database.h # tests/unit/test_native_backend.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invoke the callback during startup for envelopes associated with crashes in previous runs across the in-process, Breakpad, Crashpad, and native backends.
Retain the native daemon's dedicated crash envelope in the application run as callback-only state, separate from transport queue dumps, so successfully delivered crashes are not sent again.
Close: #885