fix: add basic Wine support and test pipeline - #2001
Open
jpnurmi wants to merge 7 commits into
Open
Conversation
Make the Windows build compatible with Wine cross-compilation by using portable header casing, limiting MSVC-only abort setup, and accepting missing UBR registry metadata. Cross-compile Windows test binaries with Clang and MinGW-w64 on Ubuntu, then run the test suite through Wine. This exercises actual Windows code paths from Linux CI. Crashpad is skipped because its vendored Windows build does not currently cross-compile with this toolchain; other skips cover host-only harnesses or specific Wine limitations.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d154eb1. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Consume the request body before returning a proxy authentication challenge so closing the connection does not produce a TCP reset. This lets Wine WinHTTP receive the challenge and retry with credentials.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2001 +/- ##
==========================================
- Coverage 74.41% 74.35% -0.06%
==========================================
Files 104 104
Lines 25913 25912 -1
Branches 4691 4690 -1
==========================================
- Hits 19282 19266 -16
- Misses 5299 5317 +18
+ Partials 1332 1329 -3 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal changes to make the tree Wine-compatible:
Cross-compile Windows test binaries with Clang and MinGW-w64 on Ubuntu, then run the test suite through Wine. This exercises actual Windows code paths from Linux CI. Crashpad is skipped because its vendored Windows build does not currently cross-compile with this toolchain; other skips cover host-only harnesses or specific Wine limitations.