Repository navigation
feat(client-reports): extend aggregator to collect event facts - #2287
Merged
Merged
Conversation
Litarnus
force-pushed
the
client-report-collect-facts
branch
from
October 21, 2026 16:32
05a0317 to
3b44e7d
Compare
Litarnus
marked this pull request as ready for review
October 22, 2026 10:43
giortzisg
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more baseline work to the
ClientReportsAggregatorto make adding them easier in the places where they occur. Also introduces thesend_client_reportoption, which defaults tofalsebecause sending client reports can cause additional latency when done beforefastcgi_finish_request.We might make them opt-out for the frameworks since we have much stronger guarantees to call them after the user facing request was already served.
Generally it's recommended to use the Agent Sidecar when using client reports to reduce latency of the main requests.