Repository navigation
Conversation
ExceptionToSentryIssueHandler extended AbstractHandler, so the processors
pushed on it never ran: the monolog.message extra kept the raw PSR-3
template (e.g. "Failed to sync user {username}") and processor-added extra
data was lost, unlike LogToSentryIssueHandler and the deprecated Handler it
replaces.
It now extends AbstractProcessingHandler like LogToSentryIssueHandler:
handle() keeps its exception and level checks and delegates to the parent,
which runs the processors before doWrite() captures the exception.
Constructor, return value and bubbling are unchanged.
Litarnus
approved these changes
Oct 22, 2026
Litarnus
left a comment
Collaborator
There was a problem hiding this comment.
Nice catch, thanks for opening the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ExceptionToSentryIssueHandlerextendsAbstractHandler, so it has no processor stack: processors pushed on the handler, or configured on it by a framework integration, never run. The visible effect is that themonolog.messageextra keeps the raw PSR-3 template instead of the interpolated message, and any extra data added by a processor is lost.LogToSentryIssueHandler, and the deprecatedHandlerthat both replace, extendAbstractProcessingHandler, so switching fromHandlerto the new pair makes the exception events lose the interpolated message, while the log events keep it.This PR makes
ExceptionToSentryIssueHandlerextendAbstractProcessingHandlerand useCompatibilityProcessingHandlerTrait, the same wayLogToSentryIssueHandlerdoes:handle()keeps its existing checks: records without aThrowableincontext.exception, or below the level, are still skipped and returnfalse. Otherwise it delegates toparent::handle(), which runs the processors and handles bubbling.doWrite(). It reads the exception again from the processed record and returns early if a processor removed it.Issues