Draft
Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 142 passed | Total: 142 | Pass Rate: 100% | Execution Time: 22.00s 📊 Comparison with Base Branch
All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 14186 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 27.64% 33.71% +6.07%
==========================================
Files 190 190 —
Lines 21358 21399 +41
Branches 7066 7096 +30
==========================================
+ Hits 5903 7213 +1310
- Misses 15455 14186 -1269
- Partials 561 700 +139Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support streaming mode in the Celery integration.
This is the first integration that contains explicit guards against creating certain spans as segments, mirroring how
start_spanworks currently -- it won't create a span if there's no transaction. In Celery, there were multiple spots that, if we just replaced all legacystart_spans with the newtraces.start_span, would've created new segment spans, leading to a change in behavior.TODO:
Issues