ref: Assign server_name to the device.name attribute to avoid server.address conflicts - #7311
Draft
alexander-alderman-webb wants to merge 8 commits into
Draft
ref: Assign server_name to the device.name attribute to avoid server.address conflicts#7311alexander-alderman-webb wants to merge 8 commits into
server_name to the device.name attribute to avoid server.address conflicts#7311alexander-alderman-webb wants to merge 8 commits into
Conversation
…address conflicts
Merged
5 tasks
alexander-alderman-webb
marked this pull request as ready for review
August 31, 2026 13:45
Contributor
Codecov Results 📊✅ 119467 passed | ⏭️ 6762 skipped | Total: 126229 | Pass Rate: 94.64% | Execution Time: 422m 9s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2485 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.27% 90.30% +0.03%
==========================================
Files 193 193 —
Lines 25617 25619 +2
Branches 9452 9452 —
==========================================
+ Hits 23125 23134 +9
- Misses 2492 2485 -7
- Partials 1435 1435 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
server.addressattribute is populated by theserver_nameinit option, as well as in integrations (e.g., in the WSGI integration). Theserver_nameoption falls back ontosocket.gethostname().In the current order, the integration value overwrites the
server_namevalue. This value is less useful in the Sentry monolith (and could break queries on theserver_namealias as there was no conflict in the transaction world).The conventions for
device.nameare more narrow thanserver.addressand align withsocket.gethostname().Issues
Closes PY-2731
Reminders
uv run ruff.feat:,fix:,ref:,meta:)