fix(quart): Skip quart-flask-patch and adjust error test for quart>=0.23 - #7320
Open
ericapisani wants to merge 1 commit into
Open
fix(quart): Skip quart-flask-patch and adjust error test for quart>=0.23#7320ericapisani wants to merge 1 commit into
ericapisani wants to merge 1 commit into
Conversation
quart-flask-patch is incompatible with quart>=0.23 due to RequestContext changes, so pin its dependency to <0.23 and skip the patch test above that version. Also update test_error_in_errorhandler: since 0.23 (db05772), Quart runs request handling inside an asyncio.TaskGroup, so exceptions propagate wrapped in an ExceptionGroup instead of bare. Fixes PY-2754 Fixes #7305
Contributor
Codecov Results 📊✅ 121930 passed | ⏭️ 6762 skipped | Total: 128692 | Pass Rate: 94.75% | Execution Time: 429m 32s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2481 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.29% 90.32% +0.03%
==========================================
Files 193 193 —
Lines 25621 25621 —
Branches 9438 9438 —
==========================================
+ Hits 23132 23140 +8
- Misses 2489 2481 -8
- Partials 1436 1435 -1Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quart-flask-patch is incompatible with quart>=0.23 due to RequestContext changes, so pin its dependency to <0.23 and skip the patch test above that version.
Also update test_error_in_errorhandler: since 0.23 (db05772), Quart runs request handling inside an asyncio.TaskGroup, so exceptions propagate wrapped in an ExceptionGroup instead of bare.
Fixes PY-2754
Fixes #7305